-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor away redundency in inequality functions #181
Refactor away redundency in inequality functions #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this already simplifies the code significantly, my question in #178 was not really about writing these functions in terms of each other, but if it would be possible to only depend on the orderTypes
function. Do you think this makes sense? Or would this cause issues that I'm not thinking of?
@rubensworks given the implementation in #180 is what you want for |
Ok, then we can change that I guess? That's the same reason why I added the |
But why would you want this? I feel like this case is way better? You have all the logic of the regularfunctions in this one file? |
I just looked again at #180, and now I understand your comment, because you did add a back-reference to regular functions from type ordering there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait with merging this one until #180 is merged.
Closes #178 |
This PR aims to resolve #178 (working together but not dependent on each other is: #180)